Fix green yellow tests #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also comment the solution, and avoid the need to clone the inputs.
Deploying ferrous-systems-rust-exercises with
|
| Latest commit: |
7024413
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87701397.ferrous-systems-rust-exercises.pages.dev |
| Branch Preview URL: | https://fix-green-yellow-tests.ferrous-systems-rust-exercises.pages.dev |
miguelraz
approved these changes
Oct 8, 2024
| // never match this secret digit again | ||
| secret_handled[s_idx] = true; | ||
| // stop comparing this guessed digit to any other secret digits | ||
| continue 'guess; |
There was a problem hiding this comment.
I would normally not advocate for the use of labelled gotos in any teaching material, but this seems simple and self-contained enough that it dovetails nicely with the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ooops - found a case our solution didn't handle.
Also re-wrote the solution to hopefully be easier to read.
And,
std::randomis coming!