Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the rust version the spec targets #541

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jan 16, 2025

Will require changes in ferrocene when this gets mirrored I think?

@pietroalbini
Copy link
Member

In ferrocene/ferrocene the extension part is already fully implemented and hooked up. Can we just add the substitution in the monorepo?

@Veykril
Copy link
Member Author

Veykril commented Jan 16, 2025

The build here will fail though if we don't set the substitution locally (and we can't hook up with substitution tooling from ferrocene_qualification given it defines a bunch of extra required args)

@Veykril Veykril force-pushed the veykril/push-wvortzvnyqyt branch 2 times, most recently from b3d0b62 to 6d733c2 Compare January 16, 2025 14:07
@Veykril Veykril force-pushed the veykril/push-wvortzvnyqyt branch from 6d733c2 to 7d1dec4 Compare January 16, 2025 14:07
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

@bors-ferrocene bors-ferrocene bot merged commit e259bbd into main Jan 16, 2025
2 checks passed
@bors-ferrocene bors-ferrocene bot deleted the veykril/push-wvortzvnyqyt branch January 16, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants