Update to 1.82 #529
Update to 1.82 #529
Conversation
Veykril
force-pushed
the
veykril/push-pxyquklquyur
branch
from
ab3c333 to
0e784c5
Compare
Veykril
force-pushed
the
veykril/push-pxyquklquyur
branch
from
5823ae2 to
7a8d9ac
Compare
src/patterns.rst
Outdated
| @@ -570,7 +567,7 @@ A :t:`reference pattern` is a :t:`pattern` that dereferences a :t:`pointer` that | |||
| is being matched. | |||
|
|
|||
| :dp:`fls_x0bmzl1315gq` | |||
| A :t:`reference pattern` is an :t:`irrefutable pattern`. | |||
| A :t:`reference pattern` is an :t:`irrefutable pattern` when its nested :t:`pattern` is an :t:`irrefutable pattern`. | |||
There was a problem hiding this comment.
I don't understand this sentence
There was a problem hiding this comment.
This is meant to state that the irrefutable pattern-ness is "inherited". So &Pattern is irrefutable when Pattern is irrefutable. Any ideas for how to phrase this better? I guess the use of "nested" here is the confusing part?
There was a problem hiding this comment.
oh, maybe emphasizing is would make it more clear...
A reference pattern is an irrefutable pattern when its nested pattern is an irrefutable pattern
otherwise it's very clear after you explain it, so feel free to ignore this suggestion
There was a problem hiding this comment.
alternative to emphasizing "is" is adding "itself"
A reference pattern is an irrefutable pattern when its nested pattern is itself an irrefutable pattern
Veykril
force-pushed
the
veykril/push-pxyquklquyur
branch
from
7a8d9ac to
6f37305
Compare
Veykril
force-pushed
the
veykril/push-pxyquklquyur
branch
from
6f37305 to
3055f43
Compare
|
made obsolete by #536 |
536: Update to 1.82 and 1.83 r=tshepang a=Veykril Builds atop of #529 Co-authored-by: Lukas Wirth <[email protected]>
No description provided.