Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criticalup run without proxies #71

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Hoverbear
Copy link
Member

Fussing with an idea to use which's logic for run instead of depending on binary proxies.

@Hoverbear Hoverbear self-assigned this Dec 3, 2024
@Hoverbear Hoverbear force-pushed the hoverbear/run-without-proxies branch from dffcda3 to 4e7e0ed Compare December 3, 2024 18:58
let found_binary = locate_binary(ctx, binary, project).await?;

let args = command.get(1..).unwrap_or(&[]);
let mut cmd = Command::new(found_binary);
Copy link
Member Author

@Hoverbear Hoverbear Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's so simple as we need to setup the PATH:

prepend_path_to_var_for_command(&mut command, "PATH", vec![additional_bin_path])?;

And the library path:

let additional_lib_path = config
.paths
.installation_dir
.clone()
.join(installation_id)
.join("lib");

@Hoverbear Hoverbear force-pushed the hoverbear/run-without-proxies branch from 75907c1 to fee32bc Compare December 3, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant