Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Github Pages action #5

Merged
merged 6 commits into from
May 23, 2024
Merged

Use Github Pages action #5

merged 6 commits into from
May 23, 2024

Conversation

Hoverbear
Copy link
Member

No description provided.

@Hoverbear Hoverbear self-assigned this May 21, 2024
@Hoverbear Hoverbear requested a review from pietroalbini May 21, 2024 20:08
pietroalbini
pietroalbini reviewed May 22, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to change the content: write to content: read permission for the whole workflow, as we don't need to push the gh-pages branch anymore.

@Hoverbear Hoverbear requested a review from pietroalbini May 22, 2024 13:51
pietroalbini
pietroalbini previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

bors-ferrocene bot added a commit that referenced this pull request May 23, 2024
@bors-ferrocene @Hoverbear
Merge #5
8755321 
5: Use Github Pages action r=pietroalbini a=Hoverbear



Co-authored-by: Ana Hobden <[email protected]>
@bors-ferrocene
Copy link
Contributor

Build failed:

@pietroalbini
Copy link
Member

Added multiple commits fixing deployment.

@pietroalbini
Copy link
Member

bors merge

@pietroalbini pietroalbini force-pushed the hoverbear/github-pages branch from 2e8e4dd to 97f14cb Compare May 23, 2024 10:35
@bors-ferrocene
Copy link
Contributor

Canceled.

@pietroalbini
Copy link
Member

Rebased.

@pietroalbini
Copy link
Member

bors merge

@bors-ferrocene
Copy link
Contributor

Build succeeded:

@bors-ferrocene bors-ferrocene bot merged commit e10fc37 into main May 23, 2024
13 checks passed
@bors-ferrocene bors-ferrocene bot deleted the hoverbear/github-pages branch May 23, 2024 11:03
@pietroalbini pietroalbini mentioned this pull request May 23, 2024
Merged
bors-ferrocene bot added a commit that referenced this pull request May 23, 2024
@bors-ferrocene @pietroalbini
Merge #11
8194ccc 
11: Fix job dependencies for github pages r=pietroalbini a=pietroalbini

Fix fallout from #5.

Co-authored-by: Pietro Albini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

@pietroalbini pietroalbini pietroalbini left review comments

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @pietroalbini @jonathanpallant