Hashes revocation review: rename method verify_payload to be more spe…

…cific. Reviewed-by: Pietro Albini <[email protected]> Ticket: https://ferroussystems.clickup.com/t/86947z6fp
ferrocene · May 22, 2024 · 0065677 · 0065677
1 parent 96478de
commit 0065677
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/crates/criticaltrust/src/keys/public.rs b/crates/criticaltrust/src/keys/public.rs
@@ -29,7 +29,7 @@ impl PublicKey {
     /// Signature verification could fail if:
     /// * The signature is present in the `RevocationInfo`.
     /// * The `RevocationInfo` cannot be verified.
-    /// * [`verify_payload`](PublicKey::verify_payload) fails.
+    /// * [`verify_payload`](PublicKey::verify_without_checking_revocations) fails.
     pub fn verify(
         &self,
         role: KeyRole,
@@ -63,7 +63,7 @@ impl PublicKey {
             }
         }
 
-        self.verify_payload(role, payload, signature)?;
+        self.verify_without_checking_revocations(role, payload, signature)?;
 
         Ok(())
     }
@@ -75,7 +75,7 @@ impl PublicKey {
     /// * The current key expired.
     /// * The signature doesn't match the payload.
     /// * The signature wasn't performed by the current key.
-    pub fn verify_payload(
+    pub fn verify_without_checking_revocations(
         &self,
         role: KeyRole,
         payload: &PayloadBytes<'_>,

diff --git a/crates/criticaltrust/src/signatures/payload.rs b/crates/criticaltrust/src/signatures/payload.rs
@@ -106,7 +106,11 @@ fn verify_signature<T: Signable>(
             None => continue,
         };
 
-        match key.verify_payload(T::SIGNED_BY_ROLE, &signed, &signature.signature) {
+        match key.verify_without_checking_revocations(
+            T::SIGNED_BY_ROLE,
+            &signed,
+            &signature.signature,
+        ) {
             Ok(()) => {}
             Err(Error::VerificationFailed) => continue,
             Err(other) => return Err(other),