-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler worker not fetching wasm binary correctly #62
base: master
Are you sure you want to change the base?
Conversation
See issue fenjalien#59 for why this patch is needed. Essentially, inside the web worker environment, the global 'Response' does not exist. As a result, wasm-bindgen's attempt to fetch the binary and parse the Response object does not work. This patch sends the entire wasm binary through to `WebAssembly.instantiate`.
Hm its annoying that it has to be done this way, and please don't format the code with tabs, use 2 spaces instead. Could you also make a bug report on the obsidian forums with your findings: https://forum.obsidian.md/c/bug-reports/7 I don't know if they're aware of this. I would make one but you seem to have a better grasp on it than I do. |
@fenjalien I reformatted the I don't have an Obsidian forums account sorry, but here's the relevant details
This means that plugins like I unfortunately couldn't find any more details than that. If you have an Obsidian forums account, publishing with those details might be enough for a developer of Obsidian to track down the issue though on their end. |
I can confirm that after building from scratch this did fix the problem for me. It does appear however that the patch is broken due to an update to the rust-compiler that broke type-inference in time 0.3.34, a dependency of the rust-section. I had to run |
Thanks for the report @lukasfri. Looks like it is time-rs/time#681 |
Fixes the `time` crate not building on rustc 1.80.1
I want to try this patch because I also see #59 errors. But when I run
I already followed this steps Obsidian Version: 1.7.6 Update: i uninstalled homebrew's rust and reinstalled rust via:
|
See issue #59 for why this patch is needed.
Essentially, inside the web worker environment, the global 'Response' does not exist. As a result, wasm-bindgen's attempt to fetch the binary and parse the Response object does not work.
This patch sends the entire wasm binary through to
WebAssembly.instantiate
.