feat(kit): mark the generated sign-in screen with both products - #64
Merged
Conversation
Every generated application is shared with the handful of people it was made for, and every one of them signs in. That screen is the largest owned surface the company has, it grows with the fleet, it costs nothing, and it said nothing at all. AuthFrame now carries two lines under the form, "Secured by Seamless Auth" and "Made with Seamless Idea", linking to each product. They sit under the sign-in screens rather than beside them, at footnote size in the muted ink role, with no logo and no lockup: a generated application has to read as its owner's, and a banner would undo the thing that makes personal software worth having. Both open in a new tab so nobody mid-sign-in loses the page, and both carry noopener without noreferrer, because the referrer is the only way either product sees that a generated application sent someone. The component's own doc said nothing here adds a link of its own. That is now the one exception, and the doc says so rather than contradicting the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61.
What is on the screen
Two lines under the sign-in form:
linking to
seamlessauth.comandseamlessidea.com.How it is kept quiet
The issue's constraint was the hard part, not the markup. A generated application has to feel like its owner's, and a banner undoes that, so:
Both links open in a new tab so that somebody part way through signing in does not lose the page, and both carry
noopenerwithoutnoreferrer. That second part is deliberate: the referrer is the only way either product ever sees that a generated application sent someone, andnoreferreris the reflex that would quietly throw it away.Verified in the browser, not only in tests
Run against the
react-vitetemplate, since how it reads is the whole point:Tests
Two, next to the component: both marks present with the right
href, and the marks positioned after the sign-in screens in the DOM. The second is what the "not the first thing a visitor reads" requirement actually reduces to in a test.Two decisions worth recording
AuthFrame. The issue flagged this as a real trade rather than an obvious yes; this PR keeps the loop whole and leaves the pricing question open, and it stays cheap to revisit.Checks
npm run validatepasses, andnpm run checkis green in both templates (react-vite20 tests,react-oauth24 tests).