Version Packages - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@seamless-auth/types@0.18.0
Minor Changes
40eb9c5: Add
magic_link_redirect_uristo the system config.An exact-match allowlist of destinations a magic link may be sent to, empty by
default.
seamless-auth-apivalidates a requested destination againstoriginstoday, which covers a target whose host is already a WebAuthn origin and cannot
express the two cases that need this: a custom application scheme such as
myapp://auth, and a universal link on a host that should not also be a WebAuthnorigin.
Exact match rather than origin comparison, because neither of those has an origin
worth comparing. Empty by default, so a deployment that sets nothing keeps comparing
against
originsexactly as it does now.Also exports
RedirectTargetSchema, which is what entries are validated with, andwhich is stricter than
z.url()on purpose.z.url()accepts anything the URL parserdoes, including
javascript:alert(1)anddata:text/html,.... A magic linkdestination is rendered as an href in an email, so one of those stored in config would
be a script-execution sink reachable through the admin system-config API. The
javascript:,data:,vbscript:,file:,blob:andabout:schemes are refused,and everything else including arbitrary application schemes is allowed, since an
allowlist of known-good schemes could not express the case this exists for.
SystemConfigPatchSchematakes the field too, so the guard applies to the admin writepath and not only to what a server seeds at boot.