Add const
s for Excel max sheet size and @assert
them in writetable!
#247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #246.
I found these limits hardcoded in other locations besides
write.jl
, so I replaced them with theconst
variables everywhere they appear.MWE:
Note that
df2
needs to fail atrow_count==1_048_576
rows because the column header puts it over the limit.I would need help formalizing this MWE into tests if that is required.