Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mocktail_image_network): add ability to mock images by url #232

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

pedrox-hs
Copy link
Contributor

@pedrox-hs pedrox-hs commented Mar 2, 2024

Status

READY

Breaking Changes

NO

Description

This Pull Request enhances the mockNetworkImages utility method by introducing an optional imageMockProvider parameter. This allows users to provide custom mock image data based on the URI. It refactors the HttpClient creation process to allow dynamic generation of mock responses based on requested URIs using this provider. Additionally, default mock data for SVG file type is provided.

Also, fix flutter_svg compatibility.

closes #239

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the enhancement New feature or request label Jun 12, 2024
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the contribution! 💙

@felangel felangel merged commit 1567041 into felangel:main Jun 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with new versions of flutter_svg
2 participants