Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(mocktail): update verify example in README.md #215

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

woolfred
Copy link
Contributor

Status

READY

Breaking Changes

NO

Description

When you simply copy & paste the example of Stub and Verify Behavior into a test it fails.
We stumbled upon it, when actually trying to verify multiple calls and were wondering why the count is off, especially after looking at the example.
Maybe this helps better in understanding how it works?

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@woolfred woolfred changed the title Update verify behaviour example in README.md docs: Update verify behaviour example in README.md Nov 1, 2023
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contribution 🙏

@felangel felangel added the documentation Improvements or additions to documentation label Dec 15, 2023
@felangel felangel changed the title docs: Update verify behaviour example in README.md docs(mocktail): update verify example in README.md Dec 15, 2023
@felangel felangel merged commit cee5c5f into felangel:main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants