Fixes #1310: mason add command ask for overwrite if brick is found #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Jul 1, 2024
packages/mason_cli/pubspec.yaml
Outdated
There was a problem hiding this comment.
Can we revert the changes to the pubspec since they aren’t related to the issue?
There was a problem hiding this comment.
Okay I'll revert the pubspec changes
felangel
reviewed
Jul 1, 2024
|
|
||
| final masonYaml = isGlobal ? globalMasonYaml : localMasonYaml; | ||
| if (masonYaml.bricks.keys.contains(brick.name)) { | ||
| final confirmation = logger.confirm( |
There was a problem hiding this comment.
Can you add some unit tests for the new functionality?
felangel
reviewed
Jul 1, 2024
| final masonYaml = isGlobal ? globalMasonYaml : localMasonYaml; | ||
| if (masonYaml.bricks.keys.contains(brick.name)) { | ||
| final confirmation = logger.confirm( | ||
| 'Existing ${brick.name} found, you want to overwrite it?', |
There was a problem hiding this comment.
Suggested change
| 'Existing ${brick.name} found, you want to overwrite it?', | |
| 'Existing ${brick.name} found. Do you want to overwrite it?', |
koukibadr
force-pushed
the
fixes-#1310-overwrite-option-while-installing
branch
from
25688ec
to
cf032d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
This is a part of #1310, "feat: ask to overwrite or not for duplicate brick name".
Changes:
Type of Change