-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mason): define BrickIgnore
class
#1227
base: master
Are you sure you want to change the base?
feat(mason): define BrickIgnore
class
#1227
Conversation
I'll have a closer look tomorrow, apologies for the delayed review! |
As discussed offline @alestiago would you be okay with pushing additional commits for the remainder of the changes so that everything can be reviewed as a whole (I know the diff will be larger) but it would be helpful for me to review everything together to make sure it all integrates well. Sorry for the delay on this and looking forward to getting it merged 🎉 |
Status
READY FOR REVIEW
Description
This is a part of #781, yet to be followed by another Pull Request to adjust the bundling logic.
Changes:
glob
dependencyBrickIgnore
classBrickIgnore.isIgnored
andBrickIgnore.fromFile
Type of Change