Fix splitting spaces in paths from statetab files #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
PR initially fixed defect SC2013. Initially wanted to code comply with current implementation of readonly-root script where rwtab's while loop didn't mangle backspaces (no SC2162 fix). So updated this PR to fix SC2162 including the one from rwtab's while loop. Has been tested on a couple of RHEL 9 setups with both rwtab and statetab entries. [EDIT] I understand that readonly-root is deprecated. But it still has full RHEL 9 support until 2031, so I do think it's a good idea to have that little bug fix included :) [/EDIT] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that paths with spaces in
/etc/statetaband/etc/statetab.d/*weren't interpreted.Since a for loop was used, bash just splitted paths at default IFS chars.
Since we could have paths with spaces like
/opt/my servicein statetab, we need to read the statetab files line per line, with IFS being '\n', which can be accomplished by using a while loop.This is already done for rwtab.