udev: Import 60-net.rules from initscripts #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 5 5
Lines 184 184
=======================================
Hits 160 160
Misses 24 24 ☔ View full report in Codecov by Sentry. |
jamacku
force-pushed
the
add-udev-rules
branch
4 times, most recently
from
2455c09
to
50583c5
Compare
msekletar
requested changes
Jul 15, 2022
rust-ifcfg-devname.spec
Outdated
| @@ -72,6 +74,8 @@ use the "default" feature of the "%{crate}" crate. | |||
| %install | |||
| %cargo_install | |||
|
|
|||
| install -m 0755 -d $(DESTDIR)$(libdir)/udev | |||
There was a problem hiding this comment.
It is not enough just to create the destination directory. There two problems, first, we also need to install actual ifcfg-devname after creating this directory. Second, ifcfg-devname is now installed into /bin which is default for binary crates. Probably the easiest solution will be adding Makefile that would have install target that installs the binary into correct location.
jamacku
commented
Jul 15, 2022
jamacku
force-pushed
the
add-udev-rules
branch
2 times, most recently
from
731c42f
to
ad6017f
Compare
Move 60-net.rules from initscripts - https://github.com/fedora-sysv/initscripts/blob/c28529c5dc64d036fe6b9ea0bf3d78f049b97445/usr/lib/udev/rules.d/60-net.rules Related to fedora-sysv/initscripts#379
Co-authored-by: Michal Sekletar <[email protected]>
jamacku
force-pushed
the
add-udev-rules
branch
from
ad6017f
to
c463c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move 60-net.rules from initscripts - @initscripts/usr/lib/udev/rules.d/60-net.rules
Related to fedora-sysv/initscripts#379