Implement rich RPM dependencies #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
That's #124 and I think it's much cleaner. |
This implements rich RPM dependencies, which are available with RPM 4.14+ (introduced in Fedora 27[1]). This means only a single line for a dependency is used. That doesn't play well with the .with_requires.commented_out approach that was implemented. This instead uses parameters. An alternative approach could be to move this to the template. [1]: https://fedoraproject.org/wiki/Changes/RPM-4.14
Member
|
There is one more alternative implementation and that is to drop the versions. Or keep just the lower bound versions. But of course it depends what is the desired outcome. Any thoughts? |
Contributor
Author
|
My use case is Foreman plugin packaging, which compiles assets at build time. This means the runtime dependencies must be present during build time. Long term I'd prefer to move to dynamically generating those, but until we drop EL8 support that won't be possible. I have debated dropping the version numbers altogether as well, which will cause it to fail later in the process. But you'll still need to keep it in sync when dependencies are added/removed so for now I'd prefer to keep them proper. After trying two approaches I think #124 is IMHO the approach to go with. If you agree, we can close this. |
Member
|
Thx for elaborating and providing more context. In addition are you using some custom template or the default one? I have provided further comments in #124, because it seems to be better starting point. |
Contributor
Author
The one that needs it right now is https://github.com/theforeman/foreman-packaging/blob/rpm/develop/gem2rpm/foreman_plugin.spec.erb |
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 6, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line for used
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
Fixes fedora-ruby#123
Fixes fedora-ruby#124
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 6, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line for used
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 6, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line per
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
While previously, this was the only option:
~~~ruby
puts list.virtualize.with_requires.to_rpm
# => Requires: rubygem(pessimistic_constraint) >= 1.0
# Requires: rubygem(pessimistic_constraint) < 2
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 6, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line per
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
While previously, this was the only option:
~~~ruby
puts list.virtualize.with_requires.to_rpm
# => Requires: rubygem(pessimistic_constraint) >= 1.0
# Requires: rubygem(pessimistic_constraint) < 2
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 7, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line per
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
While previously, this was the only option:
~~~ruby
puts list.virtualize.with_requires.to_rpm
# => Requires: rubygem(pessimistic_constraint) >= 1.0
# Requires: rubygem(pessimistic_constraint) < 2
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 7, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line per
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
While previously, this was the only option:
~~~ruby
puts list.virtualize.with_requires.to_rpm
# => Requires: rubygem(pessimistic_constraint) >= 1.0
# Requires: rubygem(pessimistic_constraint) < 2
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
voxik
added a commit
to voxik/gem2rpm
that referenced
this pull request
Jan 7, 2026
This implements support for boolean RPM dependencies [[1]], which are
available with RPM 4.14+. This allow to use only single line per
dependency:
~~~ruby
dep = Gem::Dependency.new('pessimistic_constraint', Gem::Requirement.new('~> 1.0'))
list = Gem2Rpm::RpmDependencyList.new([dep])
puts list.virtualize.booleanize.with_requires.to_rpm
# => Requires: (rubygem(pessimistic_constraint) >= 1.0 with rubygem(pessimistic_constraint) < 2)
~~~
While previously, this was the only option:
~~~ruby
puts list.virtualize.with_requires.to_rpm
# => Requires: rubygem(pessimistic_constraint) >= 1.0
# Requires: rubygem(pessimistic_constraint) < 2
~~~
Fixes fedora-ruby#123
Fixes fedora-ruby#124
[1]: https://rpm-software-management.github.io/rpm/manual/boolean_dependencies.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements rich RPM dependencies, which are available with RPM 4.14+ (introduced in Fedora 271). This means only a single line for a dependency is used. That doesn't play well with the .with_requires.commented_out approach that was implemented. This instead uses parameters.
An alternative approach could be to move this to the template. I'll submit a separate PR to demonstrate that.