Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce window for finding a good commit #630

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Reduce window for finding a good commit #630

merged 4 commits into from
Aug 7, 2024

Conversation

kwk
Copy link
Collaborator

@kwk kwk commented Aug 7, 2024

  • Only check last 100 commits.
  • Return the initial commit if no good one was found.

Fixes #628

@kwk
Reduce window for finding a good commit
ccf8a34 
- Only check last 100 commits.
- Return the initial commit if no good one was found.

Fixes #628
@kwk kwk assigned nikic Aug 7, 2024
nikic
nikic reviewed Aug 7, 2024
View reviewed changes
scripts/get-good-commit.py Outdated Show resolved Hide resolved
scripts/get-good-commit.py Outdated Show resolved Hide resolved
kwk and others added 2 commits August 7, 2024 13:34
nikic
nikic previously approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikic
Copy link
Collaborator

nikic commented Aug 7, 2024

Note that there is a python formatting failure.

@kwk
Copy link
Collaborator Author

kwk commented Aug 7, 2024

Note that there is a python formatting failure.

Probably introduced by just accepting your suggestion in github. Let me see.

@kwk kwk merged commit cf887d0 into main Aug 7, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic left review comments

Assignees

@nikic nikic

Labels
github/workflow python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce window for finding a good commit
2 participants
@kwk @nikic