This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Misc fixes #91
Open
Misc fixes #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre-Yves Chibon <[email protected]> Signed-off-by: Nils Philippsen <[email protected]>
Signed-off-by: Pierre-Yves Chibon <[email protected]>
- use dict, list, set literals and comprehensions where sensible - don't build lists from generators superfluously - don't use dict.keys(), rather the dict var itself where an iterable is expected - sorted() returns a list already - remove Python 2 compat - use f-strings, except for logging, don't use % operator there, for late interpolation - remove u-strings from comments, too Signed-off-by: Nils Philippsen <[email protected]>
Signed-off-by: Pierre-Yves Chibon <[email protected]>
Signed-off-by: Nils Philippsen <[email protected]>
- fix order - remove unused imports - use unittest.mock instead of 3rd party mock - import some oft-used objects directly rather than addressing them through their modules Signed-off-by: Nils Philippsen <[email protected]>
Signed-off-by: Nils Philippsen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #90