Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Io.swagger upgrade #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Io.swagger upgrade #66

wants to merge 1 commit into from

Conversation

cuzz22000
Copy link

Having run into an issue #65 an IllegalArgumentException is thrown when an Optional argument is in an annotated method signature . I found by upgrading to the latest Swagger2 api v1.5.0 the issue apparently vanishes.

This PR also covers the request for the v1.5.0 upgrade #58 but seems to supersedes plans for a more thorough Swagger2 integration #22. Given that this is a response to a BUG in the previous version of swagger the PR should be considered on those grounds.

I did find that the new version of the API introduces an annoying runtime dependency, org.glassfish.jersey.media.multipart.FormDataParam ,which had to be declared in the build independently.

<dependency>
            <groupId>org.glassfish.jersey.media</groupId>
            <artifactId>jersey-media-multipart</artifactId>
            <version>2.16</version>
            <scope>runtime</scope>
</dependency>

@salimane
Copy link

👍

@esiqveland
Copy link

Sweet. Please release to fix #65.

@spoon16
Copy link

spoon16 commented Sep 1, 2015

:shipit:

@jplock
Copy link

jplock commented Sep 1, 2015

I've forked this repo to https://github.com/smoketurner/dropwizard-swagger and plan to publish it to maven central under the "com.smoketurner" groupId if anyone is interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants