Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added atomic design alternative docs #671

Merged
merged 2 commits into from
May 24, 2024

Conversation

midas-png
Copy link
Contributor

Background

I've decided to update Alternatives page on Atomic Design as I know that I could help on this.

Changelog

  1. Updated Atomic Design section in Alternatives page in English and Russian.
  2. Deleted WIP notification in Atomic Design section.

Написанную мною секцию проверил на LanguageTool и в Главреде.

По главреду, чистота - 8.7, читаемость - 8.8

Copy link

netlify bot commented May 22, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit 1474098
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/66508028bad475000852341f
😎 Deploy Preview https://deploy-preview-671--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@midas-png midas-png marked this pull request as ready for review May 23, 2024 09:22
Copy link
Contributor

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks a lot, this is a very important (and long neglected) part of our docs and I'm so glad that you decided to try your hand at it :)

One suggestion I may offer is to reword the headings slightly. I assume they were derived from the notes in the WIP, but those notes are not particularly clear :)

Here are my suggestions:

  • Approach -> What is it? / Что это?
  • Applicability -> Applicability to frontend / Применимость во фронтенде
  • FSD Position -> How does it relate to FSD? / Как оно сочетается с FSD?

I'm also a bit concerned about the part where you write that Atomic Design doesn't have a layer for business logic. Mostly because FSD doesn't have one either :D Instead, FSD offers a separate level of grouping (segments) that creates designated spaces for business logic, data storage, API interactions, app configuration and other things that are relevant for a frontend application, apart from its UI. Would love to see this clarified a bit (and technically, segments can also be applied to Atomic as well, it's just that it doesn't suggest them, since it's mostly a design methodology)

@midas-png
Copy link
Contributor Author

Hi! Thank you for review. Yes, I agree, these names are better than from the WIP. As for a layer for business logic, I agree, that's what I meant, I clarified it

@midas-png midas-png requested a review from illright May 24, 2024 11:58
Copy link
Contributor

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, good to go! Thanks again :)

@illright illright merged commit 1b2da0c into feature-sliced:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants