Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete website links from example configurations #670

Merged
merged 3 commits into from
May 19, 2024

Conversation

yuki-katayama
Copy link
Contributor

@yuki-katayama yuki-katayama commented May 19, 2024

Overview

This pull request removes several outdated website links from the examples configuration file that were either no longer functioning or redundant due to redirections to the source URLs.

Changes

  • Removed specific website entries that are obsolete or duplicate the source links provided in the configuration.
  • Regarding vk audiopad, there was a link in the repository, so I used that and changed it to the website link.

Rationale

The removal of these links simplifies the information presented in the examples, ensuring that users are not misdirected by inactive or redundant URLs.

Request for Maintainers

If you find this pull request unnecessary, or if further modifications are required, please feel free to reject or suggest necessary revisions.

Just to be sure, the test has passed.

[INFO] [en] Creating an optimized production build...

✔ Client
  Compiled successfully in 7.01s

✔ Server
  


✔ Client
  Compiled successfully in 3.67s

✔ Server
  

[SUCCESS] Generated static files in "build".
[INFO] [ru] Creating an optimized production build...

✔ Client
  Compiled successfully in 2.93s

✔ Server
  

[SUCCESS] Generated static files in "build/ru".
[INFO] [uz] Creating an optimized production build...

● Client █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 serialize pack

● Server █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 stored

[SUCCESS] Generated static files in "build/uz".
$ eslint --cache "./**/*.{ts,tsx,js,jsx}" && stylelint --cache ./**/*.scss && prettier --check --cache .
Checking formatting...
All matched files use Prettier code style!

Thank you for reviewing this proposal!

Copy link

netlify bot commented May 19, 2024

Deploy Preview for pr-fsd ready!

Name Link
🔨 Latest commit e7c4df4
🔍 Latest deploy log https://app.netlify.com/sites/pr-fsd/deploys/6649c6d165311e000854e5a7
😎 Deploy Preview https://deploy-preview-670--pr-fsd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@illright
Copy link
Contributor

Hi! Good catch, these links do need to be removed. Thanks for the contribution :)

@illright illright merged commit 257e594 into feature-sliced:master May 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants