Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default custom-env-config settings caused name conflicts #3193

Open
wants to merge 6 commits into
base: dove
Choose a base branch
from

Conversation

FossPrime
Copy link
Member

@FossPrime FossPrime commented May 19, 2023

Summary

HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined cause unexpected bindings, errors and interactions with other parts of your server/app/system.

Suggested solution

Namespace them.

Additional details

This reminds me of another feathers-configuration feature, relating to path resolution, that caused unexpected issues. I chose not to include OAUTH secrets as the origin definition seems imperfect, as it somewhat duplicates the top level origins.

https://github.com/feathersjs/feathers-chat/blob/dove/feathers-chat-ts/config/custom-environment-variables.json

Screenshot 2023-06-05 14 26 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant