Add battery-full icon

[M-arcus]

No description provided.

[haylinmoore]

This would be a great inclusion

[Ecleptic]

It looks good to me!

Here's a preview:

[moeenio]

#171 Guidelines says "no fills"

[Ecleptic]

Looks like I completely missed that in the guidelines. I'll re-build it.
I need a battery in my current project.

[ashygee]

@herohamp curious why this is approved? the icon still contains a fill which is against the guidelines (#171) pointed out by @locness3.

[M-arcus]

@herohamp @ashygee I have changed the svg

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@d2ea756). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #172   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      5           
  Lines             ?     34           
  Branches          ?      3           
=======================================
  Hits              ?     34           
  Misses            ?      0           
  Partials          ?      0

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ea756...27ef596. Read the comment docs.

[ashygee]

cc @colebemis

[moeenio]

They are still fills actually. The rectangles are filled.

[M-arcus]

@locness3 Sorry, I can't see the fill. Only that the fill is set to none.

Could you please point it out?

[moeenio]

@M-arcus Strange, the Github rich diff displays a fill

[M-arcus]

@locness3 Probably because the line are thick. Should i make them thinner?

[moeenio]

@locness3 Probably because the line are thick. Should i make them thinner?

Guidelines say (#171) that icons should have a 2px stroke. Check out the guidelines about spacing.

[mittalyashu]

The battery looks great, can you add 1px of spacing around the icon.

Can you create a different version of battery like:

Battery 0	Battery 1	Battery 2	Battery 3

[csandman]

I know this is old, but I wanted to weigh in. I feel like the version by @mittalyashu doesn't quite match the guidelines for 2px wide stroke width's with the bars. I feel like the best solution to this would be to implement a similar shape but using lines instead. Here are my versions that stick with the original battery's style (using rect and line):

---

battery-full

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <rect x="1" y="6" width="18" height="12" rx="2" ry="2" />
  <line x1="23" y1="13" x2="23" y2="11" />
  <line x1="5" y1="14" x2="5" y2="10" />
  <line x1="10" y1="14" x2="10" y2="10" />
  <line x1="15" y1="14" x2="15" y2="10" />
</svg>

---

battery-medium

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <rect x="1" y="6" width="18" height="12" rx="2" ry="2" />
  <line x1="23" y1="13" x2="23" y2="11" />
  <line x1="5" y1="14" x2="5" y2="10" />
  <line x1="10" y1="14" x2="10" y2="10" />
</svg>

---

battery-low

<svg
  xmlns="http://www.w3.org/2000/svg"
  width="24"
  height="24"
  viewBox="0 0 24 24"
  fill="none"
  stroke="currentColor"
  stroke-width="2"
  stroke-linecap="round"
  stroke-linejoin="round"
>
  <rect x="1" y="6" width="18" height="12" rx="2" ry="2" />
  <line x1="23" y1="13" x2="23" y2="11" />
  <line x1="5" y1="14" x2="5" y2="10" />
</svg>

And here are the files:
battery-icons.zip

I could submit a separate pull request, what do you think @colebemis? I know you've been busy so I tried to make these match the current style (code and guidelines) as much as possible to make it easy for you haha.

[M-arcus]

Completed via lucide-icons/lucide#23