feat: Added docling and pytorch as add on #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
approved these changes
Feb 25, 2025
ntkathole
force-pushed
the
docling_extra
branch
2 times, most recently
from
a71074f to
cbe4e99
Compare
ntkathole
force-pushed
the
docling_extra
branch
4 times, most recently
from
d98454b to
c6176b1
Compare
|
It seems this is causing increase in an image size. Do we have large runners available under our github org? |
|
@ntkathole this is what I see available. Anything here work?
|
ntkathole
force-pushed
the
docling_extra
branch
3 times, most recently
from
5239ef1 to
4be9a30
Compare
ntkathole
commented
Feb 26, 2025
| @@ -162,7 +162,7 @@ docker-build: ## Build docker image with the manager. | |||
| ## Build feast docker image. | |||
| .PHONY: feast-ci-dev-docker-img | |||
| feast-ci-dev-docker-img: | |||
| cd ./../.. && make build-feature-server-dev | |||
| cd ./../.. && make build-feature-server-dev-minimal | |||
There was a problem hiding this comment.
@franciscojavierarceo Since we do not have larger runner to run kind + feast with all dependencies, either we need self-hosted runners or we need to use image with minimal dependencies installed in CI.
Currently moving from multicloud/Dockerfile.dev to multicloud/Dockerfile works in CI to run operator e2e test.
There was a problem hiding this comment.
My concern is that we miss potential breaks by using this minimal image. That's the risk here, right?
There was a problem hiding this comment.
We will be using this image just for operator e2e test, feast functionality will be tested via integration and unit tests with all dependencies installed.
@tchughesiv or someone more familiar with operator work can confirm if it's a big risk in operator testing or better way to handle this.
There was a problem hiding this comment.
this change needs to be reverted
There was a problem hiding this comment.
@ntkathole @franciscojavierarceo this must remain make build-feature-server-dev
Signed-off-by: ntkathole <[email protected]>
ntkathole
force-pushed
the
docling_extra
branch
2 times, most recently
from
01d60df to
b2e1769
Compare
Signed-off-by: ntkathole <[email protected]>
ntkathole
force-pushed
the
docling_extra
branch
from
b2e1769 to
adee3e0
Compare
|
looks like that worked! |
tchughesiv
reviewed
Mar 3, 2025
Comment on lines
+530
to
+535
| build-feature-server-dev-minimal: | ||
| docker buildx build \ | ||
| -t feastdev/feature-server:dev \ | ||
| -f sdk/python/feast/infra/feature_servers/multicloud/Dockerfile \ | ||
| --load sdk/python/feast/infra/feature_servers/multicloud | ||
|
|
There was a problem hiding this comment.
this is just a release build... its not a dev image build
There was a problem hiding this comment.
we'll need to remove this
franciscojavierarceo
pushed a commit
that referenced
this pull request
Mar 10, 2025
# [0.47.0](v0.46.0...v0.47.0) (2025-03-10) * feat!: Include PUBLIC_URL in defaultProjectListPromise URL in /ui ([2f0f7b3](2f0f7b3)) ### Bug Fixes * Add transformation_service_endpoit to support Go feature server. ([#5071](#5071)) ([5627d7c](5627d7c)) * Adding extra space on the VM to kind cluster to see if this solves the issue with memory not available with operator e2e tests. ([#5102](#5102)) ([e6e928c](e6e928c)) * Allow unencrypted Snowflake key ([#5097](#5097)) ([87a7c23](87a7c23)) * Cant add different type of list types ([#5118](#5118)) ([bebd7be](bebd7be)) * Fixing transformations on writes ([#5127](#5127)) ([95ac34a](95ac34a)) * Identify s3/remote uri path correctly ([#5076](#5076)) ([93becff](93becff)) * Increase available action VM storage and reduce dev feature-server image size ([#5112](#5112)) ([75f5a90](75f5a90)) * Move Feast to pyproject.toml instead of setup.py ([#5067](#5067)) ([4231274](4231274)) * Skip refresh if already in progress or if lock is already held ([#5068](#5068)) ([f3a24de](f3a24de)) ### Features * Add an OOTB Chat uI to the Feature Server to support RAG demo ([#5106](#5106)) ([40ea7a9](40ea7a9)) * Add Couchbase Columnar as an Offline Store ([#5025](#5025)) ([4373cbf](4373cbf)) * Add Feast Operator RBAC example with Kubernetes Authentication … ([#5077](#5077)) ([2179fbe](2179fbe)) * Added docling and pytorch as add on ([#5089](#5089)) ([135342b](135342b)) * Feast Operator example with Postgres in TLS mode. ([#5028](#5028)) ([2c46f6a](2c46f6a)) * Operator - Add feastProjectDir section to CR with git & init options ([#5079](#5079)) ([d64f01e](d64f01e)) * Override the udf name when provided as input to an on demand transformation ([#5094](#5094)) ([8a714bb](8a714bb)) * Set value_type of entity directly in from_proto ([#5092](#5092)) ([90e7498](90e7498)) * Updating retrieve online documents v2 to work for other fields for sq… ([#5082](#5082)) ([fc121c3](fc121c3)) ### BREAKING CHANGES * The PUBLIC_URL environment variable is now taken into account by default when fetching the projects list. This is a breaking change only if all these points apply: 1. You're using Feast UI as a module 2. You're serving the UI files from a non-root path via the PUBLIC_URL environment variable 3. You're serving the project list from the root path 4. You're not passing the `feastUIConfigs.projectListPromise` prop to the FeastUI component In this case, you need to explicitly fetch the project list from the root path via the `feastUIConfigs.projectListPromise` prop: ```diff const root = createRoot(document.getElementById("root")!); root.render( <React.StrictMode> - <FeastUI /> + <FeastUI + feastUIConfigs={{ + projectListPromise: fetch("/projects-list.json", { + headers: { + "Content-Type": "application/json", + }, + }).then((res) => res.json()) + }} + /> </React.StrictMode> ); ``` Signed-off-by: Harri Lehtola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds docling and torch as add on to feast.
Integrating Docling would allow users to efficiently chunk text data within Online Feature Views (ODFVs) during the write process and torch will allow conversion of feature vectors into pytorch tensors.
Which issue(s) this PR fixes:
#5037 #4890