-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RBAC Authorization in Feast Operator #4786
Open
dmartinol
wants to merge
11
commits into
feast-dev:master
Choose a base branch
from
dmartinol:auth_k8s
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,461
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchughesiv
suggested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this! only a few nits so far
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
tchughesiv
suggested changes
Nov 22, 2024
tchughesiv
suggested changes
Nov 25, 2024
tchughesiv
suggested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits ... otherwise lgtm
infra/feast-operator/internal/controller/services/services_types.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
Signed-off-by: Daniele Martinoli <[email protected]>
tchughesiv
approved these changes
Nov 27, 2024
@feast-dev/reviewers-and-approvers please TAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding support to define the kubernetes authorization manager with the Feast Operator.
ServiceAccount
that is bound to a newly createdRole
allowing toget, list, watch
the otherRoles
andRoleBindings
in the same namespace.Sample manifest to configure the deployments:
Which issue(s) this PR fixes:
Relates to #4765
Next PR will add support for the OIDC authorization.