feat: Added feast Go operator db stores support #4771
+1,176
−163
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,11 +75,13 @@ type OfflineStore struct { | |
| } | ||
|
|
||
| // OfflineStorePersistence configures the persistence settings for the offline store service | ||
| // +kubebuilder:validation:XValidation:rule="[has(self.file), has(self.store)].exists_one(c, c)",message="One selection required between file or store." | ||
| type OfflineStorePersistence struct { | ||
| FilePersistence *OfflineStoreFilePersistence `json:"file,omitempty"` | ||
| DBPersistence *OfflineStoreDBStorePersistence `json:"store,omitempty"` | ||
| } | ||
|
|
||
| // OfflineStoreFilePersistence configures the file-based persistence for the offline store service | ||
| type OfflineStoreFilePersistence struct { | ||
| // +kubebuilder:validation:Enum=dask;duckdb | ||
| Type string `json:"type,omitempty"` | ||
|
|
@@ -91,15 +93,35 @@ var ValidOfflineStoreFilePersistenceTypes = []string{ | |
| "duckdb", | ||
| } | ||
|
|
||
| // OfflineStoreDBStorePersistence configures the DB store persistence for the offline store service | ||
| type OfflineStoreDBStorePersistence struct { | ||
| // +kubebuilder:validation:Enum=snowflake.offline;bigquery;redshift;spark;postgres;feast_trino.trino.TrinoOfflineStore;redis | ||
| Type string `json:"type,omitempty"` | ||
| SecretRef *corev1.LocalObjectReference `json:"secretRef,omitempty"` | ||
| SecretKeyName string `json:"secretKeyName,omitempty"` | ||
dmartinol marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. maybe add a comment to There was a problem hiding this comment. @tchughesiv There was a problem hiding this comment.
yes ... isn't the default here the db store type? i'm saying just add a comment above the field (which will add documentation to the CRD) so the user understands this |
||
| } | ||
|
|
||
| var ValidOfflineStoreDBStorePersistenceTypes = []string{ | ||
| "snowflake.offline", | ||
| "bigquery", | ||
| "redshift", | ||
| "spark", | ||
| "postgres", | ||
| "feast_trino.trino.TrinoOfflineStore", | ||
| "redis", | ||
| } | ||
|
|
||
| // OnlineStore configures the deployed online store service | ||
| type OnlineStore struct { | ||
| ServiceConfigs `json:",inline"` | ||
| Persistence *OnlineStorePersistence `json:"persistence,omitempty"` | ||
| } | ||
|
|
||
| // OnlineStorePersistence configures the persistence settings for the online store service | ||
| // +kubebuilder:validation:XValidation:rule="[has(self.file), has(self.store)].exists_one(c, c)",message="One selection required between file or store." | ||
| type OnlineStorePersistence struct { | ||
| FilePersistence *OnlineStoreFilePersistence `json:"file,omitempty"` | ||
| DBPersistence *OnlineStoreDBStorePersistence `json:"store,omitempty"` | ||
| } | ||
|
|
||
| // OnlineStoreFilePersistence configures the file-based persistence for the offline store service | ||
|
|
@@ -111,6 +133,28 @@ type OnlineStoreFilePersistence struct { | |
| PvcConfig *PvcConfig `json:"pvc,omitempty"` | ||
| } | ||
|
|
||
| // OnlineStoreDBStorePersistence configures the DB store persistence for the offline store service | ||
| type OnlineStoreDBStorePersistence struct { | ||
| // +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore | ||
| Type string `json:"type,omitempty"` | ||
| SecretRef *corev1.LocalObjectReference `json:"secretRef,omitempty"` | ||
| SecretKeyName string `json:"secretKeyName,omitempty"` | ||
|
Comment on lines
+139
to
+141
|
||
| } | ||
|
|
||
| var ValidOnlineStoreDBStorePersistenceTypes = []string{ | ||
| "snowflake.online", | ||
| "redis", | ||
| "ikv", | ||
| "datastore", | ||
| "dynamodb", | ||
| "bigtable", | ||
| "postgres", | ||
| "cassandra", | ||
| "mysql", | ||
| "hazelcast", | ||
| "singlestore", | ||
| } | ||
|
|
||
| // LocalRegistryConfig configures the deployed registry service | ||
| type LocalRegistryConfig struct { | ||
| ServiceConfigs `json:",inline"` | ||
|
|
@@ -119,7 +163,8 @@ type LocalRegistryConfig struct { | |
|
|
||
| // RegistryPersistence configures the persistence settings for the registry service | ||
| type RegistryPersistence struct { | ||
| FilePersistence *RegistryFilePersistence `json:"file,omitempty"` | ||
| DBPersistence *RegistryDBStorePersistence `json:"store,omitempty"` | ||
| } | ||
|
|
||
| // RegistryFilePersistence configures the file-based persistence for the registry service | ||
|
|
@@ -133,6 +178,19 @@ type RegistryFilePersistence struct { | |
| S3AdditionalKwargs *map[string]string `json:"s3_additional_kwargs,omitempty"` | ||
| } | ||
|
|
||
| // RegistryDBStorePersistence configures the DB store persistence for the registry service | ||
| type RegistryDBStorePersistence struct { | ||
| // +kubebuilder:validation:Enum=sql;snowflake.registry | ||
| Type string `json:"type,omitempty"` | ||
| SecretRef *corev1.LocalObjectReference `json:"secretRef,omitempty"` | ||
| SecretKeyName string `json:"secretKeyName,omitempty"` | ||
|
Comment on lines
+184
to
+186
|
||
| } | ||
|
|
||
| var ValidRegistryDBStorePersistenceTypes = []string{ | ||
| "snowflake.registry", | ||
| "sql", | ||
| } | ||
|
|
||
| // PvcConfig defines the settings for a persistent file store based on PVCs. | ||
dmartinol marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // We can refer to an existing PVC using the `Ref` field, or create a new one using the `Create` field. | ||
| // +kubebuilder:validation:XValidation:rule="[has(self.ref), has(self.create)].exists_one(c, c)",message="One selection is required between ref and create." | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be required fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmartinol @lokeshrangineni @redhatHameed
I am not sure, what do you think ? anyone ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmartinol gave a thumbs up. @tmihalac from a code & usability standpoint... aren't these 2 fields required if the user decides to configure a db store? (i believe they are) if so, we need to make them required in the CRD.