Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding github action to run the operator end-to-end tests. #4762

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat: Adding github action to run the operator end-to-end tests. #4762

merged 1 commit into from
Nov 15, 2024

Conversation

lokeshrangineni
Copy link
Contributor

@lokeshrangineni lokeshrangineni commented Nov 14, 2024 •
edited
Loading

  • Adding github action to do the operator end-to-end testing. This action will create a kind cluster and runs the tests on it.

@lokeshrangineni lokeshrangineni changed the title Adding github action to run the end-to-end tests. feat: Adding github action to run the end-to-end tests. Nov 14, 2024
@lokeshrangineni lokeshrangineni changed the title feat: Adding github action to run the end-to-end tests. feat: Adding github action to run the operator end-to-end tests. Nov 14, 2024
@lokeshrangineni lokeshrangineni marked this pull request as ready for review November 14, 2024 21:35
@lokeshrangineni lokeshrangineni requested a review from a team as a code owner November 14, 2024 21:35
@lokeshrangineni lokeshrangineni self-assigned this Nov 14, 2024
@lokeshrangineni lokeshrangineni force-pushed the feature/operator-action-e2e-test branch 2 times, most recently from 48ca378 to 29d6d7f Compare November 14, 2024 21:55
dmartinol
dmartinol reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

franciscojavierarceo
franciscojavierarceo requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the actions upgrades from adding the operator? There have been side effects to the release process from upgrading stuff in the actions, so I'd like us to be able to revert or adjust easily without removing the operator.

@lokeshrangineni
Adding github action to do the operator end-to-end testing. This acti…
3638676 
…on will create a kind cluster and runs the tests on it.

Signed-off-by: lrangine <[email protected]>
@lokeshrangineni
Copy link
Contributor Author

Can we separate the actions upgrades from adding the operator? There have been side effects to the release process from upgrading stuff in the actions, so I'd like us to be able to revert or adjust easily without removing the operator.

I have separated out the warning fixes into separate PR

franciscojavierarceo
franciscojavierarceo reviewed Nov 15, 2024
View reviewed changes
.github/workflows/operator-e2e-integration-tests.yml

services:
kind:
# Specify the Kubernetes version
Copy link
Member

@franciscojavierarceo franciscojavierarceo Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the Kind version or the Kubernetes version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind version, my understanding is each kind image version is having associated k8 version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have revalidated again, each kind image version is mapped to the same kubernetes version.

dmartinol
dmartinol reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@dmartinol dmartinol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

franciscojavierarceo
franciscojavierarceo approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@franciscojavierarceo franciscojavierarceo merged commit d8ccb00 into feast-dev:master Nov 15, 2024
21 checks passed
shuchu pushed a commit to shuchu/feast that referenced this pull request Nov 21, 2024
@lokeshrangineni @shuchu
feat: Adding github action to run the operator end-to-end tests. (fea…
2f18527 
…st-dev#4762)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmartinol dmartinol dmartinol left review comments

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

@lokeshrangineni lokeshrangineni

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lokeshrangineni @franciscojavierarceo @dmartinol