Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tags instead of a custom invalid runtime option #1

Closed
wants to merge 1 commit into from

Conversation

fdaciuk
Copy link
Owner

@fdaciuk fdaciuk commented Jun 25, 2022

What did you implement:

Serverless 3 will throw an error if we use a provider.runtime option different from the allowed values:

Error:
Configuration error at 'provider.runtime': must be equal to one of the allowed values [dotnet6, dotnetcore3.1, go1.x, java11, java8, java8.al2, nodejs12.x, nodejs14.x, nodejs16.x, provided, provided.al2, python3.6, python3.7, python3.8, python3.9, ruby2.7]

Learn more about configuration validation here: http://slss.io/configuration-validation

This PR removes the need to use the new runtime option (rust) and uses tags.rust: true inside the function configuration.

Closes: softprops#107

How did you verify your change:

Just put a tag.rust: true in your function configuration:

functions:
  rust:
    handler: your_rust_project_name
    runtime: provided.al2
    tags:
      rust: true

What (if anything) would need to be called out in the CHANGELOG for the next release:

You can use the title of this PR.

Serverless 3 will throw an error if we use a `provider.runtime` option different from the allowed values.
This PR removes the need to use the new runtime option (`rust`) and uses `tags.rust: true` inside the function configuration.

This PR resolves softprops#107
@fdaciuk fdaciuk closed this Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is this project still being developed?
1 participant