support emscripten build #1145
Open
support emscripten build #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wengxt
reviewed
Oct 8, 2024
| event_libuv.cpp) | ||
| event_sdevent.cpp) | ||
| elseif (EMSCRIPTEN) | ||
| list(APPEND FCITX_UTILS_SOURCES event_js.cpp) # implemented in fcitx5-js |
There was a problem hiding this comment.
I don't like having an external file dependency.
I think we could somehow, create a stub for EventLoop and having a global factory class to allow external event loop implementation.
There was a problem hiding this comment.
I have no idea how to achieve that with a factory.
Added the event_js.cpp, since there is nothing specific to fcitx5-js. emscripten_async_call is generic API https://emscripten.org/docs/api_reference/emscripten.h.html#c.emscripten_async_call
There was a problem hiding this comment.
Without breaking the API, here's what you can do.
- create a stub only EventLoop that takes a EventLoopImpl as parameter.
- Create a global factory callback that allow external code to override the creation of EventLoopImpl.
- Before initialize Instance, set the factory function
In other words, use Dependency injection to make your js eventloop implementation live outside of the main repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream patch from https://github.com/fcitx-contrib/fcitx5-js