The virtual keyboard should show or hide automatically if enabled #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not fully understand the motivation of this change here. To me, it seems like the "is auto hide" mode check is pushed down to the UI level. Which seems to be wrong to me. UI's API should be simply pure, when show/hide is called, then it just show or hide, without checking any other "auto" condition. As your issues, I think the issue should be solved in other some way. |
1. When the user interacts with some applications rather than the virtual keyboard itself, the virtual keyboard should show or hide if it is enabled. 2. For example, if the user clicks a window and the window has a text input control which has the focus and accepts the input from the keyboard, then the virtual keyboard should show automatically if the auto show switch is enabled. 3. Then, if the window loses the focus, the virtual keyboard should hide automatically if the auto hide switch is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user interacts with some applications rather than the virtual keyboard itself, the virtual keyboard should show or hide if it is enabled.
For example, if the user clicks a window and the window has a text input control which has the focus and accepts the input from the keyboard, then the virtual keyboard should show automatically if the auto show switch is enabled.
Then, if the window loses the focus, the virtual keyboard should hide automatically if the auto hide switch is enabled.