Fix volatility of conversion functions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function `uuid_v7_to_timestamptz` can be immutable since given an UUID it will return the same value for eternity regardless of timezone (the returned values will compare equal regardless of the timezone). Function `uuid_timestamptz_to_v7` can be immutable since given a timestamp with a timezone it is ok to return the same random "filler" for each invocation since the random value cannot be reliabily used for anything and there is no requirement that each invocation have to return a different value. This commit also adds a `uuid_timestamptz_to_v7_stable` for those cases where a stable value is required, that is, when executions in different queries have to return a different value.
|
This pull request is provided as a proposal for how you can support both an efficient version of the conversion functions as well as providing the ability to generate different v7 UUID for the same timestamp in different queries, where that is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
uuid_v7_to_timestamptzcan be immutable since given an UUID it will return the same value for eternity regardless of timezone (the returned values will compare equal regardless of the timezone).Function
uuid_timestamptz_to_v7can be immutable since given a timestamp with a timezone it is ok to return the same random "filler" for each invocation since the random value cannot be reliabily used for anything and there is no requirement that each invocation have to return a different value.This commit also adds a
uuid_timestamptz_to_v7_stablefor those cases where a stable value is required, that is, when executions in different queries have to return a different value.