Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: remove failing tests #3680

Merged
merged 1 commit into from
Aug 18, 2024
Merged

lint: remove failing tests #3680

merged 1 commit into from
Aug 18, 2024

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Aug 18, 2024

Remove tests that are failing on revive v1.3.9. While they work on v1.3.7, they're for edge cases that vim-go can wait for revive to fix instead of pinning the version of revive at v1.3.7 in plugin/go.vim.

Once revive fixes its handling of NULL modules and GOPATH packages without modules, these tests can be re-enabled.

Remove tests that are failing on revive v1.3.9. While they work on
v1.3.7, they're for edge cases that vim-go can wait for revive to fix
instead of pinning the version of revive at v1.3.7 in plugin/go.vim.

Once revive fixes its handling of NULL modules and GOPATH packages
without modules, these tests can be re-enabled.
@bhcleek bhcleek added this to the vim-go v1.29 milestone Aug 18, 2024
@bhcleek bhcleek merged commit 790a1c2 into fatih:master Aug 18, 2024
8 checks passed
@bhcleek bhcleek deleted the lint/module branch August 18, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant