Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: fix double substitution for paths in goto_file from stacktrace window #3675

Conversation

gremat
Copy link
Contributor

@gremat gremat commented Aug 2, 2024

When the content of the stacktrace window is computed in s:show_stacktrace(), s:substituteRemotePath() is already used to map remote paths to local paths. goto_file() is intended to jump to the desired location in the source code which resides on the local machine. Thus it should use the local path and not translate the path back to the remote version.

… window

When the content of the stacktrace window is computed in s:show_stacktrace(),
s:substituteRemotePath() is already used to map remote paths to local paths.
goto_file() is intended to jump to the desired location in the source code which
resides on the local machine. Thus it should use the _local_ path and not
translate the path back to the remote version.
@bhcleek
Copy link
Collaborator

bhcleek commented Aug 3, 2024

Thank you

@bhcleek bhcleek added this to the vim-go v1.29 milestone Aug 18, 2024
@bhcleek bhcleek merged commit d3216cd into fatih:master Aug 18, 2024
2 of 8 checks passed
bhcleek added a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants