Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsp: improve debug logging #3646

Merged
merged 1 commit into from
Feb 25, 2024
Merged

lsp: improve debug logging #3646

merged 1 commit into from
Feb 25, 2024

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Feb 25, 2024

  • Use win_execute instead of win_gotoid when possible to avoid problems with textlock that can occur when completion is in progress. This isn't a full solution, so the retry has to remain in case the debug window is being created for the first time while completion is in progress. However, in nearly all other cases, the debug window will be able to be changed without making it the active window.
  • Set the log's fileencoding to utf-8 so that multibyte characters will be displayed correctly.

@bhcleek
lsp: improve debug logging
b336ecc 
* Use win_execute instead of win_gotoid when possible to avoid problems
  with textlock that can occur when completion is in progress. This
  isn't a full solution, so the retry has to remain in case the debug
  window is being created for the first time while completion is in
  progress. However, in nearly all other cases, the debug window will be
  able to be changed without making it the active window.
* Set the log's fileencoding to utf-8 so that multibyte characters will
  be displayed correctly.
@bhcleek bhcleek added this to the vim-go v1.29 milestone Feb 25, 2024
@bhcleek bhcleek merged commit 744aa99 into fatih:master Feb 25, 2024
8 checks passed
@bhcleek bhcleek deleted the lsp/debug-with-textlock branch February 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vim-go v1.29
Development

Successfully merging this pull request may close these issues.
1 participant
@bhcleek