Update syntax for version in Go mod file directive #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +61,7 @@ syntax match gomodToolchainVersion "go1\(.\d\+\)\{,2\}\(rc\d\+\)\?\([ \t-].*\)\? | |||
| highlight default link gomodToolchainVersion Identifier | |||
|
|
|||
| " match go versions | |||
| syntax match gomodGoVersion "1\.\d\+" contained | |||
| syntax match gomodGoVersion "\(1.\d\+\)\(\(.\d\+\)\|\(rc\d\+\)\)\?" contained | |||
There was a problem hiding this comment.
I think this is clearer with magic: \v(1.\d+)((.\d+)|(rc\d+))?. I think I've seen this used elsewhere in these syntax files so maybe a worthwhile change?
There was a problem hiding this comment.
I'm ok without the magic.
Since go1.21 this directive supports the same version format as the `toolchain` directive[1] (though it doesn't support any suffixes). Specifically it supports formats such as: * `1.20` (this was supported previously) * `1.21.0` * `1.21rc1` Note: patch versions do not have release candidates (e.g. `1.21.1rc2` is not valid) [1] https://go.dev/ref/mod#go-mod-file-go
matthewhughes934
force-pushed
the
support-broader-go-versions
branch
from
85352da
to
f98a2ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since go1.21 this directive supports the same version format as the
toolchaindirective[1] (though it doesn't support any suffixes). Specifically it supports formats such as:1.20(this was supported previously)1.21.01.21rc1Note: patch versions do not have release candidates (e.g.
1.21.1rc2is not valid)[1] https://go.dev/ref/mod#go-mod-file-go