Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: log more efficiently #3616

Merged
merged 2 commits into from
Dec 24, 2023
Merged

lsp: log more efficiently #3616

merged 2 commits into from
Dec 24, 2023

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Dec 24, 2023

lsp: log more efficiently
  • Do not log when in visual mode, select mode, or while waiting on
    completion. This keeps the screen from being cleared or from
    generating an exception when logging would otherwise change to the log
    window to scroll.
  • Do not change to the log window merely to write to it. The only
    operation that is now required to change to the log window is to
    scroll it, so limit the time that it's the active window to that
    single operation.

Add an option to configure the timer delay when logging LSP messages.
This is mostly useful when needing to get logs for an LSP operation when
the behavior of the operation being debugged is sensitive to a window
losing focus.
* Do not log when in visual mode, select mode, or while waiting on
  completion. This keeps the screen from being cleared or from
  generating an exception when logging would otherwise change to the log
  window to scroll.
* Do not change to the log window merely to write to it. The only
  operation that is now required to change to the log window is to
  scroll it, so limit the time that it's the active window to that
  single operation.
@bhcleek bhcleek added this to the vim-go v1.29 milestone Dec 24, 2023
@bhcleek bhcleek merged commit 425784a into fatih:master Dec 24, 2023
8 checks passed
@bhcleek bhcleek deleted the lsp-debug-log-delay branch December 24, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant