Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add Gopls disable checking when view the :GoDoc #3610

Merged
merged 1 commit into from
Dec 23, 2023
Merged

doc: Add Gopls disable checking when view the :GoDoc #3610

merged 1 commit into from
Dec 23, 2023

Conversation

rwxguo
Copy link
Contributor

@rwxguo rwxguo commented Dec 15, 2023

When g:go_gopls_enabled = 0, :GoDoc and :GoDocBrowser will not work because they are still calling go#lsp functions.

I have added checking so that :GoDoc and :GoDocBrowser can work properly when g:go_gopls_enabled = 0

@rwxguo rwxguo closed this Dec 15, 2023
@rwxguo rwxguo reopened this Dec 15, 2023
@bhcleek
Copy link
Collaborator

bhcleek commented Dec 15, 2023

thank you

@bhcleek bhcleek added this to the vim-go v1.29 milestone Dec 15, 2023
@rwxguo rwxguo changed the title Add Gopls disable checking when view the :GoDoc doc: Add Gopls disable checking when view the :GoDoc Dec 19, 2023
@rwxguo
Copy link
Contributor Author

rwxguo commented Dec 19, 2023

You're welcome

@bhcleek bhcleek merged commit dd45fb6 into fatih:master Dec 23, 2023
8 checks passed
bhcleek added a commit that referenced this pull request Dec 23, 2023
@bhcleek
update CHANGELOG.md for #3610
76e2763
@rwxguo rwxguo deleted the doc-disable-gopls branch December 27, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vim-go v1.29
Development

Successfully merging this pull request may close these issues.
2 participants
@rwxguo @bhcleek