Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sameids: fix highlighting preceded by multibyte characters #3587

Merged
merged 1 commit into from
Oct 2, 2023
Merged

sameids: fix highlighting preceded by multibyte characters #3587

merged 1 commit into from
Oct 2, 2023

Conversation

bhcleek
Copy link
Collaborator

@bhcleek bhcleek commented Sep 30, 2023

Fixes #3586

@bhcleek bhcleek added this to the vim-go v1.29 milestone Sep 30, 2023
@dunric
Copy link

dunric commented Oct 1, 2023

Thanks for the fix! It seems it does the job in my cases I've tried with source codes of various projects.

I did suspected there has to be a missing position (re-)calculation for utf8/utf16 units contents.

@bhcleek bhcleek merged commit aa1590a into fatih:master Oct 2, 2023
8 checks passed
@bhcleek bhcleek deleted the sameids/multibyte branch October 2, 2023 18:11
bhcleek added a commit that referenced this pull request Oct 2, 2023
@bhcleek
update CHANGELOG.md for #3587
1401b57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vim-go v1.29
Development

Successfully merging this pull request may close these issues.

Position for identifier highlight(GoSameIds) is miscalculated when unicode character is present
2 participants
@bhcleek @dunric