Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove :GoDefStack #1556

Closed
wants to merge 1 commit into from
Closed

Remove :GoDefStack #1556

wants to merge 1 commit into from

Conversation

arp242
Copy link
Contributor

@arp242 arp242 commented Nov 4, 2017

Fixes #1431

@bhcleek
Copy link
Collaborator

bhcleek commented Nov 5, 2017

Since ctrl-] is mapped to GoDef, I would also like to see CTRL-t mapped to CTRL-O instead of having the custom mapping for CTRL-t completely removed (personally, I use ctrl-t a lot)...

@font
Copy link

font commented Nov 8, 2017

I'm not sure that mapping ctrl-t to ctrl-o is going to work like one would expect. Specifically, ctrl-o tracks a lot more movements in the stack than just jumps via :GoDef. See my comment in #1431.

@fatih
Copy link
Owner

fatih commented Nov 10, 2017

@font is right. We need to come up with a solution that only tracks file jumps, but not mark jumps. I think there was a special command where you could feed the jumps yourself.

@arp242 arp242 added the wip label Nov 17, 2017
@arp242
Copy link
Contributor Author

arp242 commented Nov 17, 2017

Note I'm not going to work on this in the foreseeable future; I just thought it would be a quick change, but looks like a but more work is needed here. If someone wants to base their changes off this PR then they're more than welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants