Remove Kamal#112
Merged
Merged
Conversation
The app deploys to Heroku (see Procfile), not via Kamal. The kamal gem was require: false and unused, and its config (config/deploy.yml, .kamal/, bin/kamal) was dead. Remove the gem and all Kamal artifacts. This also drops the open Dependabot kamal bump (#107) as moot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove Kamal. This app deploys to Heroku (see
Procfile), not via Kamal, so the gem and its config were dead weight.What was removed
gem "kamal", require: falsefrom the Gemfile (it wasrequire: falseand never loaded).config/deploy.yml(Kamal deploy config)..kamal/(hooks samples + secrets template).bin/kamalbinstub.Verification
bundle installresolves cleanly;kamalno longer inGemfile.lock.bin/rails runner).Related
Makes the open Dependabot kamal bump (#107) moot — it can be closed.