Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring by template #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactoring by template #170

wants to merge 1 commit into from

Conversation

dukaev
Copy link

@dukaev dukaev commented Feb 13, 2019 •
edited
Loading

@dukaev
Did refactoring by template:
4185266 
require "benchmark/ips"

def fast
end

def slow
end

Benchmark.ips do |x|
  x.report("fast code description") { fast }
  x.report("slow code description") { slow }
  x.compare!
end
@dukaev dukaev changed the title Did refactoring by template Refactoring by template Feb 13, 2019
mateusdeap
mateusdeap reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@mateusdeap mateusdeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dukaev I don't know if you're already on this, but I believe that if you just add Ashwini's suggestions to your PR, in the issue this solves, we can merge it.

Thanks for the good work!

@mateusdeap
Copy link
Member

If not, that's fine. Just let me know and I can take it over.

@dukaev
Copy link
Author

dukaev commented Oct 15, 2022

@mateusdeap great. In a few days I will do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateusdeap mateusdeap mateusdeap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dukaev @mateusdeap