Skip to content

skip oneapi test if icpx doesn't exist #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
calad0i wants to merge 2 commits into from
Closed

skip oneapi test if icpx doesn't exist #1302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c640c46
skip oneapi test if icpx doesnt exist
calad0i May 28, 2025
6c1edf7
skip w/o side effect
calad0i Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions hls4ml/backends/oneapi/oneapi_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,15 @@ def compile(self, model):
try:
subprocess.run('which icpx', shell=True, cwd=builddir, check=True)
except subprocess.CalledProcessError:
try:
Copy link
Contributor

@JanFSchulte JanFSchulte Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this try - except block if the pytest import only happens when it's available?

import os

if "PYTEST_CURRENT_TEST" in os.environ:
import pytest

pytest.skip('icpx not present')
except ImportError:
pass
raise RuntimeError('Could not find icpx. Please configure oneAPI appropriately')
subprocess.run('cmake ..', shell=True, cwd=builddir, check=True)
subprocess.run('make lib', shell=True, cwd=builddir, check=True)
Expand All @@ -200,6 +209,15 @@ def build(self, model, build_type='fpga_emu', run=False):
try:
subprocess.run('which icpx', shell=True, cwd=builddir, check=True)
except subprocess.CalledProcessError:
try:
import os

if "PYTEST_CURRENT_TEST" in os.environ:
import pytest

pytest.skip('icpx not present')
except ImportError:
pass
raise RuntimeError('Could not find icpx. Please configure oneAPI appropriately')
subprocess.run('cmake ..', shell=True, cwd=builddir, check=True)
subprocess.run(f'make {build_type}', shell=True, cwd=builddir, check=True)
Expand Down
Loading