Skip to content

Conversation

@jkarneges
Copy link
Member

A few small changes to the args handling:

  • Revert config file discovery to the old behavior of explicit arg or single default location. Only the runner should use the more advanced get_config_file() which checks extra paths.
  • Revert to creating Settings objects only after checking the config file.
  • Remove config file checking from the CliArgs::verify() methods since ProxyApp and HandlerApp already do this. Notably, this avoids having a std::process::exit call in those methods.
  • When constructing the array of C strings, use Box for memory management rather than malloc/free.

@jkarneges jkarneges force-pushed the jkarneges/rework-args branch from c27a7bf to ff1dd24 Compare October 8, 2025 02:56
@jkarneges jkarneges requested a review from serra-fastly October 8, 2025 03:16
@jkarneges jkarneges merged commit 5da411e into main Oct 14, 2025
19 checks passed
@jkarneges jkarneges deleted the jkarneges/rework-args branch October 14, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants