fix(ws): commit ws request headers before upgrading #1216
Merged
+284
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
zkat/commit-headers-on-ws-upgrade
branch
from
cc766ed to
b485bad
Compare
zkat
force-pushed
the
zkat/commit-headers-on-ws-upgrade
branch
from
b485bad to
0675fec
Compare
Contributor
|
Hm, does this KVStore test fail locally for you with this branch? I haven't seen that failure before |
Contributor
Author
|
@TartanLlama I think our tests are just being flaky right now. I don't see that failure after a rerun because we're failing before, on stuff completely unrelated to the change. I literally just changed a small thing about websocket connections. |
Member
|
@zkat Fanout handoff is supposed to work the same way but it currently has the same problem. It’s earlier in the same file. While you’re in there, would you be able to fix that one along with this? |
TartanLlama
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.