Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#12): bound the right context on nested encapsulation #13

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Jan 31, 2025

Closes #12

Checklist

@Eomm Eomm self-requested a review January 31, 2025 16:59
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95
Copy link
Member Author

merging, let me know if there's further feedback @Eomm so I can open a further PR for that 👍

@metcoder95 metcoder95 merged commit 49d4df6 into fastify:main Feb 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring plugin before routes breaks all my tests
4 participants