Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fastify v4 support #11

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat: fastify v4 support #11

merged 5 commits into from
Jan 27, 2025

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Jan 25, 2025

Fixes #10

This PR adds a lightweight Fastify v4 support:

  1. The NodeJS versions are the one listed in the LTS policy
  2. So fastify v4 is not tested against NodeJS 14, 16, 18
  3. The fastify-plugin has been removed so we don't have any blockers based on this module version
  4. The @opentelemetry/* deps were always the same used for all the fastify's version
  5. We may add support for fastify v3, but this would be just a jump of faith because:

So I think that:

  • adding support for v4 is something needed by the community
  • adding support for v3 is something that someone should sponsor if needed

I think this because of this output too: https://craigory.dev/npm-burst/?package=fastify
The 61.6% of our users are still using fastify v4.

image

@mcollina
Copy link
Member

It should be tested against Node v18 - it's still there.

@Eomm
Copy link
Member Author

Eomm commented Jan 26, 2025

It should be tested against Node v18 - it's still there.

Done - I just adapted a bit tests:

  • removed t.plan because it is not there
  • find/replace t.assert to assert

Checked that the tests fail accordingly if the assertions are not good of course:

image

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit b8a4446 into main Jan 27, 2025
14 checks passed
@Eomm Eomm deleted the read-to-one branch January 27, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Fastify 4
5 participants