chore: add package-lock #16
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a package-lock.json file to enable npm caching in GitHub Actions workflows, improving CI performance. The changes also include workflow updates to use the latest action versions and switch from npm i to npm ci for more reliable installs.
- Addition of
package-lock.jsonwith lockfileVersion 3 - Removal of
publishConfigfrompackage.json(appropriate for app/tool projects) - Removal of
package-lock=falsefrom.npmrcto allow lock file generation - GitHub workflow updates to use newer action versions and enable caching
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package-lock.json | New lock file generated with npm v7+ (lockfileVersion 3) for dependency management and caching |
| package.json | Removed publishConfig section since this is an app/tool, not a published module |
| .npmrc | Removed package-lock=false directive to allow lock file creation |
| .github/workflows/emeritus-check.yml | Updated to actions/checkout@v6, actions/setup-node@v6, added check-latest and cache configuration, switched to npm ci |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
can we add the dependabot configuration?
There was a problem hiding this comment.
Alternative is we disable the caching in the workflow?
I tend to agree with that
There was a problem hiding this comment.
@Eomm, okay so should i revert all of this and just remove the caching?
Required to use the caching feature of
actions/setup-node. See: https://github.com/fastify/org-admin/actions/runs/19744227114Have also removed publishConfig as this probably won't be published to npm as it's an app/tool, not a module, just like our website repo.
Alternative is we disable the caching in the workflow?
Checklist
and the Code of conduct