-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace husky with pre-commit ensure dist integrity #515
Conversation
This should avoid the unintentional commit of the dist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh but we need the dist to be generated and committed when we do releases!
@simoneb |
Apologies but I don't see the value in this solution. I like the simplicity of building the action automatically when committing, so that dist is always aligned with the source code. The only downside to this approach is that sometimes dist is changed in PRs that are not changing the source code, and the most likely reason is that some packages got updated in the PR author's branch. I don't find this a major issue since the dist will nonetheless be recreated when we release the action by the very same process. |
I understand. I use this type of logic in the actions at my employer. See e.g. So it results in two things:
|
Checklist
npm run test
andnpm run benchmark
and the Code of conduct