Adding an option to modify the non-existent root directory warning (#524) #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen143
force-pushed
the
custom-missing-root-warning
branch
from
9455ecf to
14a25ac
Compare
xen143
changed the title
xen143
force-pushed
the
custom-missing-root-warning
branch
from
14a25ac to
34a522c
Compare
|
Force-pushes above were for fixing minor issues I have overlooked, such as extra semicolon, etc. |
|
Hi, thanks for the PR! Why do you think this is useful? |
Hi, two reasons occur to me:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an option to change the default warning message when the root directory (or one of the root directories) is not found. (#524)
Checklist
npm run testandnpm run benchmarkand the Code of conduct